Workbench session image promotion #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion` to fetch version
…uild-fix-tests Use env var for WORKBENCH_SESSION_INIT_VERSION or default to `get-version` to fetch version
…uild Add release target for workbench-session-init image
Adds the WORKBENCH_SESSION_INIT variable to the manual build flow
Update build-manual.yaml
Merge versions job into workbench-session-init job
* add go program * add multi-stage build dockerfile * add positron * fix path * update err msgs and reuse file info * merge comments * enhance file copying with otiai10/copy package and update Dockerfile * remove uneeded components * add shared_run to common deps * fix component filename * update Dockerfile to use ubuntu:22.04 base image, as the scratch image doesn't work nicely with GOSS * remove test var --------- Co-authored-by: Ian Pittwood <[email protected]>
Co-authored-by: Skye Turriff <[email protected]>
Feature/workbench session
bschwedler
requested review from
zachhannum
and removed request for
costrouc and
ianpittwood
zachhannum
reviewed
Nov 26, 2024
temp removal of workbench-session-init from github actions release build
Update build-bake.yaml
zachhannum
approved these changes
Nov 27, 2024
|
@zachhannum is it OK if the preview/daily builds still run for the session init container? (as they did in the above workflow) |
Yep, preview/daily builds are still OK! We are using them for QA prior to the release. Thanks! |
1 similar comment
Yep, preview/daily builds are still OK! We are using them for QA prior to the release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the
workbench-sessionimage.