Add rule for X11 development files #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imager package needs the X11 development headers and library. The lack of this rule has led to errors in GitHub workflows starting with ubuntu-24.04, where the package does not appear to come pre-installed anymore. Signed-off-by: Rodrigo Tobar <[email protected]>
glin
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Looks good, thanks! We will also rebuild imager (+dependent packages) for Posit Package Manager once this is published, some time tomorrow morning.
For the Alpine issue, I haven't seen that and CI here seems to be fine. Maybe it's some sort of transient network issue? It should be fine to ignore as long as the CI here passes though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imager package (and others) needs the X11 development headers and library. The lack of this rule has led to errors in GitHub workflows starting with ubuntu-24.04, where the package does not appear to come pre-installed anymore.
Related issues:
I very recently found out about this piece of infrastructure, so let me know if I'm doing something wrong.
I also found that the alpine images wouldn't build locally (
curlcouldn't resolve some hostnames, butwgetcould...). Should I treat those as local issues, or would you be happy for a separate PR moving alpine Docker images to use wget instead of curl?