Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests, test GPG signatures and wheels #3

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

shepherdjerred
Copy link
Contributor

@shepherdjerred shepherdjerred commented Oct 27, 2023

  • Add snapshot tests for our parser
  • Add tests for wheels
  • Add tests for GPG signatures
  • Do not include gpg_signature in the metadata since Twine does not output that field

Related to https://github.com/rstudio/package-manager/issues/11950

@shepherdjerred shepherdjerred force-pushed the sj/10-27-tests_add_snapshot_test branch 7 times, most recently from 9bf39e3 to b7e65e9 Compare October 30, 2023 20:51
@shepherdjerred shepherdjerred marked this pull request as ready for review October 30, 2023 20:52
@shepherdjerred shepherdjerred force-pushed the sj/10-27-tests_add_snapshot_test branch 12 times, most recently from 9e542a6 to 5b45e96 Compare October 30, 2023 22:54
Copy link
Collaborator

@jmwoliver jmwoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I like all the discrepancies it helped us find.

I can't remember, is dependabot set up in a way that it will update the twine version that is used in the GHA for testing? I just want to make sure we are always testing against the latest version of twine to make sure our parsing is always correct.

Edit: should the GHA run daily and have errors output to the #ppm-bots channel?

@shepherdjerred
Copy link
Contributor Author

This is really great! I like all the discrepancies it helped us find.

I can't remember, is dependabot set up in a way that it will update the twine version that is used in the GHA for testing? I just want to make sure we are always testing against the latest version of twine to make sure our parsing is always correct.

We do a pip install twine on every run of the action, so the latest version will always run.

Edit: should the GHA run daily and have errors output to the #ppm-bots channel?

Sure, we can try this.

@shepherdjerred
Copy link
Contributor Author

@jmwoliver I've scheduled the action to run weekly. Failures use a Slack webhook to notify #ppm-bots.

CleanShot 2023-11-03 at 11 22 38@2x

@shepherdjerred shepherdjerred merged commit 4dcc03f into main Nov 3, 2023
1 of 2 checks passed
@shepherdjerred shepherdjerred deleted the sj/10-27-tests_add_snapshot_test branch November 3, 2023 18:24
@shepherdjerred
Copy link
Contributor Author

I meant to enable auto-merge... whoops. I think everything was passing, though. I'll follow up and tag a new release once everything looks good.

@jmwoliver
Copy link
Collaborator

@shepherdjerred No worries, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants