Support S3 Objects List ETag map #126
Conversation
| @@ -157,6 +158,114 @@ func (a *DefaultAwsOps) BucketObjects(bucket, s3Prefix string, concurrency int, | |||
| } | |||
| } | |||
|
|
|||
| func (a *DefaultAwsOps) BucketObjectsMap(bucket, s3Prefix string, concurrency int, recursive bool, reg *regexp.Regexp) (map[string]string, error) { | |||
There was a problem hiding this comment.
No need to review this whole method in detail. I'll annotate what changed, apart from the signature.
| return | ||
| } | ||
|
|
||
| bm := getObjectsAllMap(resp, s3Prefix, reg) |
There was a problem hiding this comment.
This is the only line that differs materially from BucketObjects. It calls the new getObjectsAllMap method instead of getObjectsAll.
| binaryMeta[strings.TrimPrefix(s[1], s3Prefix)] = *key.ETag | ||
| } | ||
| } else { | ||
| binaryMeta[strings.TrimPrefix(*key.Key, s3Prefix)] = *key.ETag |
There was a problem hiding this comment.
This method is nearly identical to the existing getObjectsAll method except that it returns a map and sets the map key/value pairs here instead of simply appending to a string array.
| @@ -19,6 +19,7 @@ import ( | |||
| type AwsOps interface { | |||
| BucketDirs(bucket, s3Prefix string) ([]string, error) | |||
| BucketObjects(bucket, s3Prefix string, concurrency int, recursive bool, reg *regexp.Regexp) ([]string, error) | |||
| BucketObjectsMap(bucket, s3Prefix string, concurrency int, recursive bool, reg *regexp.Regexp) (map[string]string, error) | |||
There was a problem hiding this comment.
Looks good, I'd just suggest making this more obvious that it's a map of ETag values. That could be a comment, but maybe renaming the method works better. Or if it's possible we'd need more metadata in the future, a map of structs that might someday contain LastModified time or whatever.
Adds a
BucketObjectsMapmethod that returns a map of S3 keys to ETag values. This method is nearly identical to the existingBucketObjectsmethod, but differs slightly to return a map with the ETag values.