Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buffer chart example #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add buffer chart example #187

wants to merge 1 commit into from

Conversation

colearendt
Copy link
Contributor

TODO:

  • revisit defaults
  • strip out unnecessary elements
  • add extraObjects or helpers for deploying priorityClasses (although that could also be considered to be at the wrong "level" / hierarchy)
  • add ci / testing / linting

@jonlinca
Copy link

Thanks for incorporating this. As a reference, this is how we implemented ours. The numbers aren't as important as the globalDefault

# priority.yaml

apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
 name: placeholder
value: 0
preemptionPolicy: Never
globalDefault: false
description: 'placeholder'
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
 name: normal
value: 1
preemptionPolicy: Never
globalDefault: true # default
description: 'normal'
# placeholder.yaml

apiVersion: apps/v1
kind: Deployment
metadata:
  name: placeholder
spec:
  replicas: 4 # this is implementation specific
  selector:
    matchLabels:
      app: placeholder
  template:
    metadata:
      labels:
        app: placeholder
  spec:
    terminationGracePeriodSeconds: 0 # important
    priorityClassName: placeholder # important
    nodeSelector:
      rsc: content # this is implementation specific
    containers:
    - image: k8s.gcr.io/pause
      name: placeholder
      resources:
        requests:
          memory: 1024M

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants