Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DataTables Source Files: Addressing Website Changes and File Inconsistencies #1147

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shrektan
Copy link
Collaborator

@shrektan shrektan commented Aug 17, 2024

The process for updating DataTables source files has changed due to modifications on the DataTables.net website. The site no longer provides zip files for download, and the file content differs from previous versions. Consequently, the entire update process requires revision.

I have implemented the tools/downloaded_src_files.R script, which can download similar source files from the DataTables.net website. However, more time and effort are needed to fix the update_DT.R script.

Several issues have been observed:

  • Many CSS files are missing from the new downloads.
  • There are inconsistencies in the file structure and content.
  • While the minification issue has been addressed, some non-minified files still exist (this problem has been resolved).

Further investigation and development are necessary to fully adapt our update process to these changes and ensure all required files are properly downloaded and integrated.

fixes #1141

@shrektan shrektan marked this pull request as draft August 17, 2024 10:20
@stla
Copy link
Collaborator

stla commented Aug 17, 2024

Awesome. Personnally I was totally discouraged by this amount of work. Thanks!

@Osteribo
Copy link

Super excited for the DataTables v2+ update :)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade DataTables to v1.13.11
4 participants