Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always update filter widgets with preset searchCols #1115

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Always update filter widgets with preset searchCols #1115

merged 2 commits into from
Jan 21, 2024

Conversation

mikmart
Copy link
Contributor

@mikmart mikmart commented Jan 21, 2024

Fixes #998.

Apply preset searchCols consistently by triggering input and trigger, just like with updateSearch in #1111.

yihui
yihui approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much cleaner! Thank you!

@yihui yihui merged commit feee8ae into rstudio:main Jan 21, 2024
10 checks passed
@mikmart mikmart deleted the searchcols branch January 22, 2024 16:42
AhmedKhaled945 pushed a commit to AhmedKhaled945/DT that referenced this pull request Feb 2, 2024
@mikmart @AhmedKhaled945
Always update filter widgets with preset searchCols (rstudio#1115)
53c23c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

searchCols don't update slider range when server=TRUE
2 participants
@mikmart @yihui