Important bugfix for Python 3 ... #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has_key() does not work anymore https://stackoverflow.com/questions/1323410/has-key-or-in
According to --help, no arguments are excepted. And arguments are apperently also not processed.
The catch for "Reading failed." is not neccessary in my opinion. If sparkup is used like sparkup < file and file cannot be opened, the shell will give an error. For sparkup itself, it should never be a problem to read from stdin. Catching KeyboardInterrupt here was an error: the variable "lines" is used later on and it will be undefined when Ctrl-C is pressed. ^CParse error. Check your input. <class 'UnboundLocalError'> local variable 'lines' referenced before assignment I would just wrap the try-except for KeyboardInterrupt around the main code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and a few more fixes and enhancements.
Please see commits for details.
And thank you for this great tool!
It only had a problem in my environment (Python 3 on Arch) because command line options did not work, e.g.
--no-last-newline. This is now fixed.