test: try to fix CI

rspack-contrib · Sep 8, 2024 · fc33080 · fc33080
1 parent 4a79f89
commit fc33080
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/test/jsx-hmr/index.test.ts b/test/jsx-hmr/index.test.ts
@@ -3,14 +3,19 @@ import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { type Page, expect, test } from '@playwright/test';
 import { createRsbuild, loadConfig } from '@rsbuild/core';
-import { pluginVueJsx } from '../../src';
+import { getRandomPort } from '../helper';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
 test('should render', async ({ page }) => {
   const rsbuild = await createRsbuild({
     cwd: __dirname,
-    rsbuildConfig: (await loadConfig({ cwd: __dirname })).content,
+    rsbuildConfig: {
+      ...(await loadConfig({ cwd: __dirname })).content,
+      server: {
+        port: getRandomPort(),
+      },
+    },
   });
 
   const { server, urls } = await rsbuild.startDevServer();
@@ -32,7 +37,12 @@ test('should render', async ({ page }) => {
 test('should update', async ({ page }) => {
   const rsbuild = await createRsbuild({
     cwd: __dirname,
-    rsbuildConfig: (await loadConfig({ cwd: __dirname })).content,
+    rsbuildConfig: {
+      ...(await loadConfig({ cwd: __dirname })).content,
+      server: {
+        port: getRandomPort(),
+      },
+    },
   });
 
   const { server, urls } = await rsbuild.startDevServer();
@@ -74,7 +84,12 @@ test.describe('vue jsx hmr', () => {
     page = await browser.newPage();
     const rsbuild = await createRsbuild({
       cwd: __dirname,
-      rsbuildConfig: (await loadConfig({ cwd: __dirname })).content,
+      rsbuildConfig: {
+        ...(await loadConfig({ cwd: __dirname })).content,
+        server: {
+          port: getRandomPort(),
+        },
+      },
     });
 
     const result = await rsbuild.startDevServer();
@@ -172,6 +187,7 @@ test.describe('vue jsx hmr', () => {
   });
 
   // not pass
+  // see https://github.com/web-infra-dev/rsbuild/pull/2018
   test.skip('hmr: vue script lang=jsx', async () => {
     await page.locator('.script').click();
     await expect(page.locator('.script')).toHaveText('script 5');

diff --git a/test/jsx-hmr/rsbuild.config.ts b/test/jsx-hmr/rsbuild.config.ts
@@ -2,7 +2,6 @@ import { defineConfig } from '@rsbuild/core';
 import { pluginBabel } from '@rsbuild/plugin-babel';
 import { pluginVue } from '@rsbuild/plugin-vue';
 import { pluginVueJsx } from '@rsbuild/plugin-vue-jsx';
-import { getRandomPort } from '../helper';
 
 export default defineConfig({
   plugins: [
@@ -12,9 +11,6 @@ export default defineConfig({
     }),
     pluginVueJsx(),
   ],
-  server: {
-    port: getRandomPort(),
-  },
   performance: {
     buildCache: false,
   },