Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure adding ending line to package.json #17

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: ensure adding ending line to package.json #17

merged 1 commit into from
Oct 30, 2024

Conversation

fi3ework
Copy link
Member

Align with

create-rstack/src/index.ts

Line 311 in bb67c6b

fs.writeFileSync(targetPackage, `${JSON.stringify(mergedJson, null, 2)}\n`);
.

chenjiahan
chenjiahan approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan changed the title fix: ensure adding ending line fix: ensure adding ending line to package.json Oct 30, 2024
@chenjiahan chenjiahan merged commit 5e9e512 into rspack-contrib:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fi3ework @chenjiahan