Do not set last retired fed p2sh script in new commitFederation impl #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
force-pushed
the
update_svp_state_from_uc
branch
2 times, most recently
from
efabbb1 to
99bdde2
Compare
julia-zack
force-pushed
the
remove_last_retired_p2sh_script_setting
branch
from
503aca7 to
0113e2a
Compare
Base automatically changed from
update_svp_state_from_uc
to
update_state_svp
November 11, 2024 19:30
nathanieliov
approved these changes
Nov 12, 2024
marcos-iov
force-pushed
the
update_state_svp
branch
from
a84f8a7 to
272f561
Compare
julia-zack
force-pushed
the
update_state_svp
branch
from
0c6aa68 to
4083234
Compare
julia-zack
force-pushed
the
remove_last_retired_p2sh_script_setting
branch
from
0113e2a to
6983bb2
Compare
Base automatically changed from
update_state_svp
to
feature/powpeg_validation_protocol-phase4
November 13, 2024 20:32
marcos-iov
reviewed
Nov 15, 2024
| @@ -733,12 +734,11 @@ private FederationChangeResponseCode commitPendingFederation(PendingFederation c | |||
| // set proposed federation | |||
| Federation proposedFederation = buildFederationFromPendingFederation(currentPendingFederation); | |||
| provider.setProposedFederation(proposedFederation); | |||
| setNewActiveFederationCreationBlockHeight(); | |||
There was a problem hiding this comment.
Should this be done at this point? Shouldn't we set this value after the proposed federation is validated? If the validation fails we'd end up with an invalid value here, right?
There was a problem hiding this comment.
we discussed this when developing phase1, the idea was that the activation period remain the same. But yes it makes sense to do it after the validation.
julia-zack
force-pushed
the
remove_last_retired_p2sh_script_setting
branch
from
6d61919 to
80b0d63
Compare
marcos-iov
approved these changes
Nov 19, 2024
|
marcos-iov
merged commit 3b02692
into
feature/powpeg_validation_protocol-phase4
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last-retired-federation script shouldn't be set in new commitFederation implementation, since we will set the to-be-active-federation after its validation.