Express the amount value in weis for peg-out related events #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
force-pushed
the
rskip427-integration
branch
from
084e84e to
e17da01
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Assertions.assertEquals(15L + federationConstants.getFederationActivationAge(activations), Long.valueOf(new String(dataList.get(2).getRLPData(), StandardCharsets.UTF_8)).longValue()); | ||
| assertEquals( | ||
| 15L + federationConstants.getFederationActivationAge(activations), | ||
| Long.valueOf(new String(dataList.get(2).getRLPData(), StandardCharsets.UTF_8)).longValue() |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
marcos-iov
force-pushed
the
rskip427-integration
branch
from
41cc91a to
65b7650
Compare
julia-zack
previously approved these changes
Oct 18, 2024
marcos-iov
force-pushed
the
rskip427-integration
branch
from
65b7650 to
6e9194b
Compare
Update rskj-core/src/test/java/co/rsk/peg/BridgeSupportReleaseBtcTest.java Co-authored-by: julia zack <[email protected]> Update test names Co-authored-by: julia zack <[email protected]> Rename tests in BridgeSupportReleaseBtcTest
marcos-iov
force-pushed
the
rskip427-integration
branch
from
6e9194b to
8220d12
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
approved these changes
Oct 24, 2024
nathanieliov
approved these changes
Oct 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of RSKIP427
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
rit:disable-rskip427