Move flyover methods from BridgeSupport to BridgeUtils #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this intended to be used in the context of the svp |
julia-zack
force-pushed
the
refactor/move_flyover_methods
branch
from
69561ab to
d48faf9
Compare
marcos-iov
reviewed
Sep 18, 2024
| @ParameterizedTest | ||
| @MethodSource("derivationHashAndRedeemScriptArgs") | ||
| void getFlyoverAddress_fromRealValues_shouldReturnSameRealAddress(Keccak256 flyoverDerivationHash, Script redeemScript) { | ||
| Address flyoverAddress = new Address(btcMainnetParams, "33y8JWrSe4byp3DKmy2Mkyykz2dzP8Lmvn"); |
There was a problem hiding this comment.
Check sonar warning, you can use Address.fromBase58 here
marcos-iov
merged commit ad4d3de
into
feature/powpeg_validation_protocol-phase2
4 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.