-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a flyover redeem script builder #2727
Conversation
Remove unused import Remove mistaken reason Minor refactor Make flyover rs builder receive a keccak256 hash instead of sha256 one Refactors
…o RedeemScriptCreationException
rskj-core/src/main/java/co/rsk/peg/bitcoin/FlyoverRedeemScriptBuilderImpl.java
Fixed
Show fixed
Hide fixed
|
||
@ParameterizedTest | ||
@MethodSource("invalidDerivationHashArgsProvider") | ||
void addFlyoverDerivationHashToRedeemScript_withInvalidPrefix_shouldThrowFlyoverRedeemScriptCreationException(Keccak256 flyoverDerivationHash) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about improving test name adding whenInvalidPrefix
?:
addFlyoverDerivationHashToRedeemScript_whenInvalidPrefix_shouldThrowFlyoverRedeemScriptCreationException
} | ||
|
||
@Test | ||
void addFlyoverDerivationHashToRedeemScript_shouldReturnRedeemScriptWithFlyoverDerivationHash() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whenValidFlyoverDerivationHash
? WDYT?:
addFlyoverDerivationHashToRedeemScript_whenValidFlyoverDerivationHash_shouldReturnRedeemScriptWithFlyoverDerivationHash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a name suggestion
rskj-core/src/main/java/co/rsk/peg/bitcoin/FlyoverRedeemScriptBuilderImpl.java
Outdated
Show resolved
Hide resolved
import co.rsk.bitcoinj.script.Script; | ||
import co.rsk.crypto.Keccak256; | ||
|
||
public interface FlyoverRedeemScriptBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why merge it into the master
branch instead of the integration branch, wip/fed-scripts-refactors-integration
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes it easier to integrate all the changes we are working on in different branches
Quality Gate passedIssues Measures |
Description
Create a flyover redeem script builder to be used in substitution of the one provided by bitcoinj-thin. Looking to decouple Bridge related logic from bitcoinj-thin
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: