Register fundtx change #2714
Closed
Register fundtx change #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-zack
force-pushed
the
add_method_to_check_svp_period
branch
from
73703d4 to
4d18d92
Compare
julia-zack
force-pushed
the
register_fundtx_change
branch
3 times, most recently
from
3d4d58a to
e5cce24
Compare
julia-zack
changed the base branch from
add_method_to_check_svp_period
to
recreate_valid_block_stored_chain
julia-zack
changed the base branch from
recreate_valid_block_stored_chain
to
add_method_to_check_svp_period
julia-zack
force-pushed
the
register_fundtx_change
branch
from
2f80201 to
9be77e9
Compare
julia-zack
force-pushed
the
add_method_to_check_svp_period
branch
from
4d18d92 to
f84b459
Compare
julia-zack
force-pushed
the
register_fundtx_change
branch
from
9be77e9 to
0b60713
Compare
Reorder rskip
Add tests Refactor Rename variable
Add key to storage index Remove declaration of svp fund tx hash since it is not being used yet. Remove _KEY suffix
Remove _KEY suffix. Save proposed federation the same way as pending one
Add proposedFederationIsSet logic Getting rid of proposedFederationIsSet logic. Add isProposedFederationSet logic. Add rskip419 check in saveProposedFederation method Save null version when proposed federation is null Remove unnecessary private method Refactor Removes null activations from tests
Make variable final Improve test name Use all activations instead of lovell Improve null handling
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Minor refactor Improve comment Add test case Throw exception when there is no storage version for non-null proposed federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Reorders and renames tests Rebases Appends SVP prefix to FUND_TX_HASH_UNSIGNED and refactors tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases Removes _ from the key Using arrowhead631 Rebases Rebases Renames saveFundTransactionUnsignedHash to saveSvpFundTransactionUnsignedHash Renames FundTransactionUnsignedHash instance fields
Remove unnecessary private method Refactor
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Add test case
…d federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases
Adds test to assert empty is returned when hash hasn't been set or saved Renames svp fields to match the RSKIP419 description. Adds more tests. Using standard. Renames test
Improve variable name Add comment Minor refactors Improve comments. Minor refactors Improve comments Refactor Add tests for commitFederationAccordingToActivations Remove unnecessary semicolon Refactor to improve testing and readability Add test cases Remove some tests. Make bridge event logger not a mock. Make some methods private instead of protected. Fix log message Improve test name Change test name Move reused method to utility class. Use real block instead of a mock Make methods to be private instead of protected
Add method to utils
Fix sonar complains Add missing import Move method to test class Remove unused imports
…y to bridge storage index key
… to bridge storage provider Remove svp fund tx tests from federation storage provider tests, and adds them to bridge storage provider tests Get rid of sonar complains Add get methods to bridge Put save, set and get tests in same nested class
…n bridge storage provider
Create saveSvpSpendTxWaitingForSignatures method
julia-zack
force-pushed
the
register_fundtx_change
branch
from
6a3fd9f to
a6e294a
Compare
julia-zack
changed the base branch from
feature/powpeg_validation_protocol-phase2
to
save_fund_tx_signed_instead_of_hash
julia-zack
force-pushed
the
register_fundtx_change
branch
from
a6e294a to
8256285
Compare
|
julia-zack
force-pushed
the
save_fund_tx_signed_instead_of_hash
branch
3 times, most recently
from
14712e3 to
45b96c4
Compare
marcos-iov
changed the base branch from
save_fund_tx_signed_instead_of_hash
to
feature/powpeg_validation_protocol-phase2
marcos-iov
changed the base branch from
feature/powpeg_validation_protocol-phase2
to
save_fund_tx_signed_instead_of_hash
julia-zack
force-pushed
the
save_fund_tx_signed_instead_of_hash
branch
from
45b96c4 to
e9a26b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since the fund transaction will be treated as a pegout, its change will eventually be attempted to be registered through existing
registerBtcTransactionmethod.When that happen, and after recognizing and processing it as a pegout, we have to save its hash (now signed) in the corresponding storage entry, that meaning we have to add some extra checks to recognize this special transaction.
So, if validation process is ongoing, we will check if the received transaction is the fund transaction.
We say that the validation process is ongoing if: proposedFederation exists, and validation period is not ended, i.e., currentRskBlock < proposedFederationCreationBlockNumber + svpPeriodDuration
.
IN THIS PR
This pr creates a new private method,
processSvpFundTransactionHashSigned, that:svpFundTransactionSignedHashstorage entry, and the value saved in svpFundTransactionUnsignedHash storage entry is removed