Create SVP spend tx hash unsigned storage entry #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apancorb
commented
Aug 28, 2024
| @@ -25,6 +25,7 @@ public enum BridgeStorageIndexKey { | |||
|
|
|||
| SVP_FUND_TX_HASH_UNSIGNED("svpFundTxHashUnsigned"), | |||
| SVP_FUND_TX_HASH_SIGNED("svpFundTxHashSigned"), | |||
| SVP_SPEND_TX_HASH_UNSIGNED("svpSpendTxHashUnsigned"), | |||
There was a problem hiding this comment.
Should we put the same name as the one that appears in the RSKIP?
There was a problem hiding this comment.
I prefer how you did it to be consistent with the naming convention of the rest of the entries.
There was a problem hiding this comment.
That's a good question, if we keep this name we need to update the RSKIP. Let's check with @julia-zack when she's back
nathanieliov
approved these changes
Aug 28, 2024
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol
branch
from
a6a59b0 to
1c84a9d
Compare
marcos-iov
changed the base branch from
feature/powpeg_validation_protocol
to
feature/powpeg_validation_protocol-phase1
marcos-iov
changed the base branch from
feature/powpeg_validation_protocol-phase1
to
feature/powpeg_validation_protocol-phase2
marcos-iov
force-pushed
the
feat/svp_spend_tx_hash_storage_index
branch
from
ceddc6a to
9a6b09e
Compare
|
marcos-iov
approved these changes
Aug 28, 2024
marcos-iov
merged commit f9c3c6a
into
feature/powpeg_validation_protocol-phase2
6 checks passed
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just as we did with the fund transaction unsigned hash, we need to save the spend transaction hash to be able to identify it when trying to register it later.
Motivation and Context
https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP419.md