Create new settleReleaseRequest method to perform common actions when creating pegouts #2692
Conversation
… creating pegouts
| pegoutsWaitingForConfirmations.add(pegoutTransaction, rskExecutionBlockNumber, releaseCreationTxHash); | ||
| } | ||
|
|
||
| private void savePegoutTxSigHash(BtcTransaction pegoutTx) { |
There was a problem hiding this comment.
this method was not modified, only moved to be closed where its being used.
|
| } | ||
| } else { | ||
| pegoutWaitingForConfirmations.add(generatedTransaction, rskExecutionBlock.getNumber()); | ||
| private void settleReleaseRequest(PegoutsWaitingForConfirmations pegoutsWaitingForConfirmations, BtcTransaction pegoutTransaction, Keccak256 releaseCreationTxHash, Coin requestedAmount) { |
There was a problem hiding this comment.
I don't think we need to pass around the pegoutsWaitingForConfirmations, we can simply get it from the storageProvider right?
There was a problem hiding this comment.
yes, thats right, but the getPegoutsWaitingForConfirmations could throw an IOException that has to be handled all over the code. See for example in processPegoutsInBatch and processPegoutsIndividually, that the map is an input of the method already handled in processPegoutRequests method.
I thought it was better to do it this way to have less impact. But let me know what you think!
There was a problem hiding this comment.
Yeah, no big deal. Thanks
There was a problem hiding this comment.
thanks to you :)
marcos-iov
merged commit 2c6380e
into
feature/powpeg_validation_protocol
-Create a new settleReleaseRequest that perform all the needed actions whenever creating a pegout.
-Get rid of existing addToPegoutsWaitingForConfirmations method.