Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on error handler for snap blocks #2666

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

asoto-iov
Copy link
Contributor

@asoto-iov asoto-iov commented Aug 2, 2024

The main purpose of this PR is to add the onStateChunkResponseError method, so if during the process of a stateChunkResponse, an error happens we ask for the same stateChunk again and to another peer if possible.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@asoto-iov asoto-iov force-pushed the add_on_error_handler_for_snap_blocks branch from d739f70 to 46d1f85 Compare August 2, 2024 14:42
@asoto-iov asoto-iov force-pushed the add_on_error_handler_for_snap_blocks branch from 4bdb8b1 to a565ccc Compare August 7, 2024 12:56
@rmoreliovlabs
Copy link
Contributor

The changes look good from what I’ve seen so far—nice work! To help me review everything thoroughly, could you add a bit more context? Specifically:

  • A brief overview of what’s been changed and why.
  • Implementation Details: How the new error handling works in practice, including how it integrates with the SnapshotProcessor class and the processStateChunkResponse and processSnapStatusResponse method

This extra info will help me get a clearer picture of how everything fits together and make the review process smoother, appreciate your help with this!

Applying suggestions

Co-authored-by: Nazaret García Revetria <[email protected]>
Copy link

Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I just have a few comments.

@fmacleal fmacleal merged commit 8fc7aa0 into snap-v4-final Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants