-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on error handler for snap blocks #2666
Conversation
d739f70
to
46d1f85
Compare
4bdb8b1
to
a565ccc
Compare
The changes look good from what I’ve seen so far—nice work! To help me review everything thoroughly, could you add a bit more context? Specifically:
This extra info will help me get a clearer picture of how everything fits together and make the review process smoother, appreciate your help with this! |
rskj-core/src/main/java/co/rsk/net/sync/BlockConnectorHelper.java
Outdated
Show resolved
Hide resolved
Applying suggestions Co-authored-by: Nazaret García Revetria <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I just have a few comments.
The main purpose of this PR is to add the onStateChunkResponseError method, so if during the process of a stateChunkResponse, an error happens we ask for the same stateChunk again and to another peer if possible.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: