Feature/initcode size limit using transaction creations #2665

fmacleal · 2024-08-02T10:28:06Z

Adding the verification of initcode size limit for the contract creation during transaction execution

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Tests for the changes have been added (for bug fixes / features)
Requires Activation Code (Hard Fork)

Other information:

rskj-core/src/main/java/org/ethereum/core/TransactionExecutor.java

rskj-core/src/main/java/org/ethereum/vm/GasCost.java

rskj-core/src/main/java/org/ethereum/core/TransactionExecutor.java

asoto-iov

Maybe it would be nice to add the test cases suggested by the EIP-3860:

Tests should include the following cases:

Creation transaction with gas limit enough to cover initcode cost
Creation transaction with gas limit enough to cover intrinsic cost except initcode cost
CREATE/CREATE2/creation transaction with len(initcode) at MAX_INITCODE_SIZE
CREATE/CREATE2/creation transaction with len(initcode) at MAX_INITCODE_SIZE+1

rskj-core/src/main/java/org/ethereum/core/Transaction.java

rskj-core/src/main/java/org/ethereum/core/TransactionExecutor.java

rskj-core/src/test/java/co/rsk/test/DslFilesTest.java

rskj-core/src/test/java/co/rsk/vm/VmDslTest.java

rskj-core/src/test/java/org/ethereum/rpc/Web3ImplLogsTest.java

In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification

In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification - Adding scenarios of test for the contract creation with DSL - The validation for the initCode size test was added - The validation is based on the RSKIP that enables it - Validation added for the contractCreation during transaction execution Finished the implementation of transactionCost and initcode size validation - All the logic related with transaction cost was changed to meet the new cost criteria - More tests were added to be sure that the flow is following the RSKIP438 - Tests were added to validate that this cost and validation doesn't impact before reach the activation height Applied some suggestions from review Adding tests to validate the failure if we don't have enough gas to cover initCode

In order to have the exact same logic for the initcode cost calculation, we introduced some new classes that can be easily reused by the TransactionExecutor and VM classes. This way, if this logic change, we won't have to change the code in multiple places. It was also introduced an interface for it, so we can expand this idea and in the future, be able to calculate total transactions just calling a method to calculate it independent of the logic used.

In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification

rskj-core/src/main/java/org/ethereum/cost/InitcodeCostCalculator.java

rskj-core/src/main/java/org/ethereum/cost/CostCalculator.java

rskj-core/src/main/java/org/ethereum/cost/InitcodeCostCalculator.java

rskj-core/src/main/java/org/ethereum/vm/program/Program.java

rskj-core/src/test/java/co/rsk/core/TransactionTest.java

rskj-core/src/test/java/org/ethereum/rpc/Web3ImplLogsTest.java

Co-authored-by: Nazaret García Revetria <[email protected]>

…tcode_size_limit_using_transaction_creations

nagarev

LGTM! Good documenting on the DSL files! 🚀

rskj-core/src/main/java/co/rsk/net/handler/TxTimestamp.java

rmoreliovlabs · 2024-09-03T02:01:08Z

Other than the comment I left, LGTM! Great work on handling this complex task

rskj-core/src/main/java/org/ethereum/core/Transaction.java

rskj-core/src/main/java/org/ethereum/cost/InitcodeCostCalculator.java

rskj-core/src/main/java/org/ethereum/vm/program/Program.java

rskj-core/src/main/java/org/ethereum/vm/GasCost.java

Applying suggestions from reviews Co-authored-by: Vovchyk <[email protected]>

* Initcode validation for opcodes contract creation - Adding scenarios of test for the contract creation with DSL - The validation for the initCode size test was added - The validation is based on the RSKIP that enables it - Validation added for the contractCreation during transaction execution - In order to have the exact same logic for the initcode cost calculation, we introduced some new classes that can be easily reused by the TransactionExecutor and VM classes. This way, if this logic change, we won't have to change the code in multiple places. It was also introduced an interface for it, so we can expand this idea and in the future, be able to calculate total transactions just calling a method to calculate it independent of the logic used. - Adding scenarios of test for the contract creation with DSL - The validation is based on the RSKIP that enables it * Added the remaining test scenarios for contracts with opcode creation * Applying suggestions from review * Applying some more suggestions from review ---------

…tcode_size_limit_using_transaction_creations

sonarqubecloud · 2024-09-06T13:59:15Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* Initial constants and config for the max initcode size In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification - Adding scenarios of test for the contract creation with DSL - The validation for the initCode size test was added - The validation is based on the RSKIP that enables it - Validation added for the contractCreation during transaction execution Finished the implementation of transactionCost and initcode size validation - All the logic related with transaction cost was changed to meet the new cost criteria - More tests were added to be sure that the flow is following the RSKIP438 - Tests were added to validate that this cost and validation doesn't impact before reach the activation height Applied some suggestions from review Adding tests to validate the failure if we don't have enough gas to cover initCode * Refactor from the Initcode cost calculation In order to have the exact same logic for the initcode cost calculation, we introduced some new classes that can be easily reused by the TransactionExecutor and VM classes. This way, if this logic change, we won't have to change the code in multiple places. It was also introduced an interface for it, so we can expand this idea and in the future, be able to calculate total transactions just calling a method to calculate it independent of the logic used. * Applying some more suggestions from review Co-Authored-By: Nazaret García Revetria <[email protected]> Co-Authored-By: Vovchyk <[email protected]>

fmacleal force-pushed the feature/introduce_initcode_size_limit branch from 3fd6e2d to 8b74286 Compare August 2, 2024 10:29

fmacleal force-pushed the feature/initcode_size_limit_using_transaction_creations branch 3 times, most recently from bcefff3 to 6ee3c68 Compare August 6, 2024 17:33

fmacleal marked this pull request as ready for review August 6, 2024 17:33

Vovchyk requested changes Aug 7, 2024

View reviewed changes

asoto-iov reviewed Aug 7, 2024

View reviewed changes

fmacleal force-pushed the feature/initcode_size_limit_using_transaction_creations branch from e561020 to 5a1ed48 Compare August 8, 2024 15:53

fmacleal requested review from asoto-iov and Vovchyk August 9, 2024 12:01

fmacleal force-pushed the feature/introduce_initcode_size_limit branch from 8b74286 to 482204c Compare August 12, 2024 12:21

fmacleal force-pushed the feature/initcode_size_limit_using_transaction_creations branch from 5a1ed48 to f5dbbe0 Compare August 12, 2024 12:58

asoto-iov approved these changes Aug 13, 2024

View reviewed changes

fmacleal added 2 commits August 23, 2024 19:14

Initial constants and config for the max initcode size

383697f

In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification

fmacleal force-pushed the feature/initcode_size_limit_using_transaction_creations branch from f5dbbe0 to 25d1e0a Compare August 23, 2024 17:14

fmacleal requested a review from a team as a code owner August 23, 2024 17:14

RIT Release Bot and others added 2 commits August 23, 2024 19:17

Initial constants and config for the max initcode size

59943d6

In order to implement the verification of initcode size, necessary for the RSKIP438, we need the constant value with the max allowed value. So we can start to validate and use it on the logic of the verification

fmacleal force-pushed the feature/introduce_initcode_size_limit branch from 482204c to 59943d6 Compare August 23, 2024 17:19