-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-2028: calldata gas cost reduction #2030
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also some tests are failing due to a bad mock for config.getActivationConfig()
I think you should keep the feature disabled and only activate it for the new tests you will add so you can assert the new calculated values.
990e215
to
2e39a88
Compare
15efd57
to
9216fae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
08348f8
to
63554e0
Compare
Kudos, SonarCloud Quality Gate passed! |
Co-authored-by: Vovchyk <[email protected]>
Co-authored-by: Vovchyk <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implementation of the EIP-2028 proposal. The proposal is about reducing the gas cost of Calldata (GTXDATANONZERO = TX_NO_ZERO_DATA) from its current value of 68 gas per non-zero byte to 16. This translates to an increase of the block size (measured in bytes).
Motivation and Context
The EIP-2028 is a scalability proposal for the Ethereum network, thinking in the L2 as a way to scale the network. The commitments from L2 networks are placed in the L1 by a transaction with the collected data as a calldata. That is why we need to reanalyze and reduce the gas cost of the bytes of the calldata field.
Readers who know nothing about rollups can figure out that this proposal can reduce some operating costs for L2 rollups. It will be harder for them to infer the other impact - for any given RSK block gas limit, this reduction allows us to convey more L2 transaction data (e.g. token transfers), which improves the transaction processing capacity (throughput) of the rollup.
How Has This Been Tested?
It has not been tested.
One of the possible issues is the network delay of transmitting the block between peers, while the other is the block processing time.
Tested should be oriented in those two aspects.
Types of changes
Checklist: