Addressing comments

rsksmart · Nov 29, 2024 · e637f99 · e637f99
1 parent 5f6b972
commit e637f99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/...um/core/ContractCreatingRollbackTest.java → ...core/ContractCreatingDslRollbackTest.java b/...um/core/ContractCreatingRollbackTest.java → ...core/ContractCreatingDslRollbackTest.java
@@ -12,7 +12,7 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
-class ContractCreatingRollbackTest {
+class ContractCreatingDslRollbackTest {
 
     @Test
     void testCreateExecutionFailsAfter453IsRollingBack() throws FileNotFoundException, DslProcessorException {

diff --git a/rskj-core/src/test/resources/dsl/453_rollback_during_creation/exceeding_code_size b/rskj-core/src/test/resources/dsl/453_rollback_during_creation/exceeding_code_size
@@ -5,14 +5,10 @@ comment
 // the contract source code
 
 contract BytecodeFactory {
-    event ContractDeployed(address contractAddress);
-
-    // Función para desplegar un contrato con `create2` a partir de un bytecode conocido
-    function deployContract(bytes memory bytecode, uint256 salt) public returns (address) {
+    function deployContractWithCreate2WithTheCodePassedInParameter(bytes memory bytecode, uint256 salt) public returns (address) {
         address contractAddress;
 
         assembly {
-            // Crear el contrato usando `create2` y asignar la dirección a `contractAddress`
             contractAddress := create2(0, add(bytecode, 0x20), mload(bytecode), salt)
         }