Refactor test names. Remove unnecessary casting

rsksmart · Oct 6, 2023 · c8a0ef3 · c8a0ef3
1 parent 05cabdf
commit c8a0ef3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rskj-core/src/test/java/co/rsk/peg/FederationSupportTest.java b/rskj-core/src/test/java/co/rsk/peg/FederationSupportTest.java
@@ -74,7 +74,7 @@ void whenNewFederationIsNullThenActiveFederationIsGenesisFederation() {
         when(provider.getNewFederation())
             .thenReturn(null);
         when(bridgeConstants.getGenesisFederation())
-            .thenReturn((StandardMultisigFederation) genesisFederation);
+            .thenReturn(genesisFederation);
 
         assertThat(federationSupport.getActiveFederation(), is(genesisFederation));
     }

diff --git a/rskj-core/src/test/java/co/rsk/peg/StandardMultisigFederationTest.java b/rskj-core/src/test/java/co/rsk/peg/StandardMultisigFederationTest.java
@@ -121,19 +121,19 @@ void redeemScript() {
     }
 
     @Test
-    void testArrayEquals_P2SHScript() {
+    void getP2SHScript() {
         ScriptBuilder p2shScriptBuilder = new ScriptBuilder();
         p2shScriptBuilder.op(ScriptOpCodes.OP_HASH160);
         p2shScriptBuilder.data(Hex.decode("57f76bf3ab818811c740929ac7a5e3ef8c7a34b9"));
         p2shScriptBuilder.op(ScriptOpCodes.OP_EQUAL);
 
         Script p2shScript = p2shScriptBuilder.build();
 
-        Assertions.assertArrayEquals(federation.getP2SHScript().getProgram(), p2shScript.getProgram());
+        Assertions.assertEquals(federation.getP2SHScript(), p2shScript);
     }
 
     @Test
-    void testEquals_Address() {
+    void getAddress() {
         Assertions.assertEquals("2N1GMB8gxHYR5HLPSRgf9CJ9Lunjb9CTnKB", federation.getAddress().toBase58());
     }