Addressing security comments regarding variables

rsksmart · Oct 18, 2024 · 7fa87b7 · 7fa87b7
1 parent d00dc7e
commit 7fa87b7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/.github/workflows/rit.yml b/.github/workflows/rit.yml
@@ -135,14 +135,16 @@ jobs:
         uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
         env:
           SLACK_BOT_TOKEN: ${{ secrets.GHA_SLACK_NOTIFICATION_TOKEN }}
+          github_event_pull_request_title: ${{ github.event.pull_request.title }}
+          github_event_pull_request_html_url: ${{ github.event.pull_request.html_url }}
         with:
           channel-id: ${{ vars.GHA_SLACK_NOTIFICATION_CHANNEL }}
           payload: |
             {
               "attachments": [
                 {
                   "color": "good",
-                  "text": "*PASSED*: :white_check_mark: - *${{ github.event.pull_request.title }}* \n*Pull request*: ${{ github.event.pull_request.html_url }} \n*Pipeline*: ${{ env.BUILD_URL }} \n*Branches used*: \n- rskj:`${{ env.RSKJ_BRANCH }}` \n- fed:`${{ env.POWPEG_BRANCH }}` \n- rit:`${{ env.RIT_BRANCH }}`"
+                  "text": "*PASSED*: :white_check_mark: - *${{ env.github_event_pull_request_title }}* \n*Pull request*: ${{ env.github_event_pull_request_html_url }} \n*Pipeline*: ${{ env.BUILD_URL }} \n*Branches used*: \n- rskj:`${{ env.RSKJ_BRANCH }}` \n- fed:`${{ env.POWPEG_BRANCH }}` \n- rit:`${{ env.RIT_BRANCH }}`"
                 }
               ]
             }
@@ -152,14 +154,16 @@ jobs:
         uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
         env:
           SLACK_BOT_TOKEN: ${{ secrets.GHA_SLACK_NOTIFICATION_TOKEN }}
+          github_event_pull_request_title: ${{ github.event.pull_request.title }}
+          github_event_pull_request_html_url: ${{ github.event.pull_request.html_url }}
         with:
           channel-id: ${{ vars.GHA_SLACK_NOTIFICATION_CHANNEL }}
           payload: |
             {
               "attachments": [
                 {
                   "color": "danger",
-                  "text": "*FAILED*: :x: - *${{ github.event.pull_request.title }}* \n*Pull request*: ${{ github.event.pull_request.html_url }} \n*Pipeline*: ${{ env.BUILD_URL }} \n*Branches used*: \n- rskj:`${{ env.RSKJ_BRANCH }}` \n- fed:`${{ env.POWPEG_BRANCH }}` \n- rit:`${{ env.RIT_BRANCH }}`"
+                  "text": "*FAILED*: :x: - *${{ env.github_event_pull_request_title }}* \n*Pull request*: ${{ env.github_event_pull_request_html_url }} \n*Pipeline*: ${{ env.BUILD_URL }} \n*Branches used*: \n- rskj:`${{ env.RSKJ_BRANCH }}` \n- fed:`${{ env.POWPEG_BRANCH }}` \n- rit:`${{ env.RIT_BRANCH }}`"
                 }
               ]
             }