Skip to content

Commit

Permalink
Adding a comment to make clearer the use of currentFeePerKb variable.
Browse files Browse the repository at this point in the history
Removing Unnecessary Comment

Removing Unnecessary Vote

- Removing unnecessary vote since it doesn't help to go straight to the point to the sense of the test method.
  • Loading branch information
wilmerrootstock authored and marcos-iov committed Jun 26, 2024
1 parent b0faaed commit 6f62827
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions rskj-core/src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class FeePerKbIT {
private final FeePerKbConstants feePerKbConstants = FeePerKbMainNetConstants.getInstance();
private FeePerKbSupport feePerKbSupport;
private SignatureCache signatureCache;
private Coin currentFeePerKb;
private Coin currentFeePerKb; // it is used to guarantee the value from getFeePerKb() contains the value expected

@BeforeAll
void setUp() {
Expand Down Expand Up @@ -465,12 +465,7 @@ void voteFeePerKbChange_whenVotingSameCurrentFeePerKbValue_shouldSetValueVoted()
//It still has the previous voting round value
assertFeePerKbValue(currentFeePerKb);

// Second vote for a different value, different authorizer
voteFeePerKb(differentFeePerKbVote, FeePerKbVoteCaller.SECOND_AUTHORIZED.getRskAddress());
//It still has the previous voting round value
assertFeePerKbValue(currentFeePerKb);

// Third vote from authorizer 3, same value as the first one voted from authorizer 1
// Second vote from authorizer 3 is the same as first vote
voteFeePerKb(sixteenthFeePerKbVote, FeePerKbVoteCaller.THIRD_AUTHORIZED.getRskAddress());
currentFeePerKb = sixteenthFeePerKbVote;

Expand Down

0 comments on commit 6f62827

Please sign in to comment.