-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MRENCLAVE extractor tool #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some unit tests. At least of the core logic classes. Also, would you be able to put all this under an sgx
module? And potentially split into separate files to have smaller modules. Thanks.
Sounds good. I'll add the unit tests and split into smaller modules. Marking this as a drat in the meantime |
Adds a middleware utility that extracts the MRENCLAVE value from a signed enclave binary.
6f8b2af
to
402e60c
Compare
- Split logic into smaller modules - Added unit tests
402e60c
to
8e0d23b
Compare
from sgx.sgxtypes.sgx_enclave_properties import EnclaveProperties | ||
|
||
|
||
class EnclaveBinary: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves a module of its own I would think. And we don't need to unit test the main
, just this class should be enough.
We decided to change the approach to a script that calls into |
Adds a middleware utility that extracts the MRENCLAVE value from a signed enclave binary.