Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MRENCLAVE extractor tool #220

Closed
wants to merge 2 commits into from

Conversation

italo-sampaio
Copy link
Collaborator

Adds a middleware utility that extracts the MRENCLAVE value from a signed enclave binary.

Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some unit tests. At least of the core logic classes. Also, would you be able to put all this under an sgx module? And potentially split into separate files to have smaller modules. Thanks.

@italo-sampaio
Copy link
Collaborator Author

We need some unit tests. At least of the core logic classes. Also, would you be able to put all this under an sgx module? And potentially split into separate files to have smaller modules. Thanks.

Sounds good. I'll add the unit tests and split into smaller modules. Marking this as a drat in the meantime

@italo-sampaio italo-sampaio marked this pull request as draft November 19, 2024 16:58
Adds a middleware utility that extracts the MRENCLAVE value from a signed enclave binary.
@italo-sampaio italo-sampaio force-pushed the feature/mrenclave-extractor branch from 6f8b2af to 402e60c Compare November 19, 2024 23:18
- Split logic into smaller modules
- Added unit tests
@italo-sampaio italo-sampaio force-pushed the feature/mrenclave-extractor branch from 402e60c to 8e0d23b Compare November 19, 2024 23:21
@italo-sampaio italo-sampaio marked this pull request as ready for review November 19, 2024 23:25
from sgx.sgxtypes.sgx_enclave_properties import EnclaveProperties


class EnclaveBinary:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserves a module of its own I would think. And we don't need to unit test the main, just this class should be enough.

@italo-sampaio
Copy link
Collaborator Author

We decided to change the approach to a script that calls into oesign: #221

@italo-sampaio italo-sampaio deleted the feature/mrenclave-extractor branch November 21, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants