Hotfix/transaction pending fixes

prisma/rsk-explorer-database.sql

@@ -142,6 +142,7 @@ input VARCHAR NOT NULL,
 status VARCHAR NOT NULL,
 timestamp VARCHAR NOT NULL DEFAULT CAST(DATE_PART('epoch', NOW()) AS VARCHAR)
 );
+CREATE INDEX ON transaction_pending(timestamp);
 
 CREATE TABLE transaction_in_pool (
 hash VARCHAR(66),

prisma/schema.prisma

@@ -304,6 +304,8 @@ model transaction_pending {
   input            String @db.VarChar
   status           String @db.VarChar
   timestamp        String @default(dbgenerated("(date_part('epoch'::text, now()))::character varying")) @db.VarChar
+
+  @@index([timestamp])
 }
 
 model tx_pool {

src/lib/servicesUtils.js

@@ -19,7 +19,7 @@ export async function insertBlock (number, blocksBase, { log, tipBlock = false }
 
       // insert block
       let savingTime = Date.now()
-      await block.save()
+      await block.save(tipBlock)
       savingTime = Date.now() - savingTime
 
       log.info(`Block ${number} saved. Fetched in ${fetchingTime} ms. Saved in ${savingTime} ms.`)

src/repositories/blocks.repository.js

@@ -35,7 +35,7 @@ export function getBlocksRepository (prismaClient) {
     insertOne (data) {
       return prismaClient.block.createMany({ data: rawBlockToEntity(data), skipDuplicates: true })
     },
-    async saveBlockData (data) {
+    async saveBlockData (data, tipBlock) {
       const { block, transactions, internalTransactions, events, tokenAddresses, addresses, balances, latestBalances, status } = data
       if (!transactions.length && block.number > 0) throw new Error(`Invalid block ${block.number}. Missing transactions`)
 
@@ -59,9 +59,11 @@ export function getBlocksRepository (prismaClient) {
           queries.push(txPendingRepository.deleteOne({ hash: tx.hash }))
         }
 
-        // Set status 'REMOVED' to any old transactions stuck on database
-        const oneHourAgo = String(Math.floor(new Date().getTime() / 1000) - 3600)
-        queries.push(txPendingRepository.updateMany({ timestamp: { lte: oneHourAgo } }, { status: 'REMOVED' }))
+        // Set status 'REMOVED' to any old transactions stuck on database every 120 blocks
+        if (tipBlock && block.number % 120 === 0) {
+          const oneHourAgo = String(Math.floor(new Date().getTime() / 1000) - 3600)
+          queries.push(txPendingRepository.updateMany({ timestamp: { lte: oneHourAgo } }, { status: 'REMOVED' }))
+        }
 
         return queries
       }

src/services/classes/Block.js

@@ -37,7 +37,7 @@ export class Block extends BcThing {
     }
   }
 
-  async save () {
+  async save (tipBlock = false) {
     const { number, forceSaveBcStats } = this
     let data
     try {
@@ -54,7 +54,7 @@ export class Block extends BcThing {
         data.status = this.status
 
         // save block and all related data
-        await this.repository.saveBlockData(data)
+        await this.repository.saveBlockData(data, tipBlock)
 
         // save blockchain stats. Only for tip blocks (requires block and addresses inserted)
         if (this.isTipBlock || forceSaveBcStats) {