wip: failing scope

.github/workflows/slither.yml

@@ -1,21 +1,30 @@
 name: Slither Analysis
-on: [push]
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
 jobs:
   analyze:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      security-events: write
     steps:
-      - uses: actions/checkout@v4
+    - name: Checkout repository
+      uses: actions/checkout@v4
 
-      - name: Run Slither
-        uses: crytic/[email protected]
-        continue-on-error: true
-        id: slither
-        with:
-          sarif: results.sarif
-          fail-on: none
-          node-version: 18
+    - name: Run Slither
+      uses: crytic/[email protected]
+      id: slither
+      with:
+        node-version: 18
+        sarif: results.sarif
+        fail-on: none
 
-      - name: Upload SARIF file
+    - name: Upload SARIF file
       uses: github/codeql-action/upload-sarif@v3
       with:
         sarif_file: ${{ steps.slither.outputs.sarif }}

hardhat.config.ts

@@ -22,8 +22,8 @@ import "./tasks/erc1155/base-uri";
 import "./tasks/erc1155/contract-uri";
 
 // Environment variable setup
-const RSK_MAINNET_RPC_URL = process.env.RSK_MAINNET_RPC_URL;
-const RSK_TESTNET_RPC_URL = process.env.RSK_TESTNET_RPC_URL;
+const RSK_MAINNET_RPC_URL = process.env.RSK_MAINNET_RPC_URL || 'https://public-node.rsk.co';
+const RSK_TESTNET_RPC_URL = process.env.RSK_TESTNET_RPC_URL || 'https://public-node.testnet.rsk.co';
 const PRIVATE_KEY = process.env.PRIVATE_KEY;
 
 // Ensure environment variables are configured