Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix coinmarketcap client tests #108

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix: fix coinmarketcap client tests #108

merged 3 commits into from
Oct 18, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Oct 18, 2023

What

  • restore the coinmarketcap handler in dev_price_ticker

Why

  • it could be used for dev purposes
  • it's used to test the coinmarketcap client

@antomor antomor self-assigned this Oct 18, 2023
@franciscotobar franciscotobar merged commit d827008 into ROLLUP-449/prepare-forced-exit-account Oct 18, 2023
2 checks passed
@antomor antomor deleted the ROLLUP-379/proxy_ticket_fix branch October 19, 2023 06:53
antomor added a commit that referenced this pull request Oct 19, 2023
@antomor @franciscotobar
fix: fix coinmarketcap client tests (#108)
ff1536d 
* fix: fix coinmarketcap client tests

* style: apply fmt

* test: fix parallel tests

---------

Co-authored-by: Francisco Tobar <[email protected]>
franciscotobar added a commit that referenced this pull request Oct 19, 2023
@franciscotobar @antomor
ROLLUP-449/prepare-forced-exit-account (#106)
03e7619 
* feat: refactor forcedExit script

* refactor: server initialization

* refactor: PR comments

* fix: fix coinmarketcap client tests (#108)

* fix: fix coinmarketcap client tests

* style: apply fmt

* test: fix parallel tests

---------

Co-authored-by: Francisco Tobar <[email protected]>

* Update docker-compose.yml

Co-authored-by: franciscotobar <[email protected]>

---------

Co-authored-by: Antonio Morrone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar left review comments

Assignees

@antomor antomor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @franciscotobar