Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(complete-withdrawals): add the completeWithdrawals field #23

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat(complete-withdrawals): add the completeWithdrawals field #23

merged 1 commit into from
Nov 3, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Sep 29, 2023

What

  • add the 'completeWithdrawals' field in the config type

Why

  • because the server returns that field in the /v0.2/config endpoint
  • that endpoint could be used to configure the dapp accordingly

Important

This field will be available only after merging the server PR

References

LordCheta
LordCheta approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@LordCheta LordCheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

annipi
annipi approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@annipi annipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@sergio-jara sergio-jara merged commit 12709a6 into rsksmart:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordCheta LordCheta LordCheta approved these changes

@annipi annipi annipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antomor @annipi @LordCheta @sergio-jara