Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-137/Unnecessary domainSeparator field in Request #34

Closed
wants to merge 6 commits into from
Closed

PP-137/Unnecessary domainSeparator field in Request #34

wants to merge 6 commits into from

Conversation

AndresQuijano
Copy link
Contributor

@AndresQuijano AndresQuijano commented Jun 16, 2022 •
edited by antomor
Loading

What

  • Modifies the contracts and tests in order to avoid passing the domain separator as part of the request and also as function parameters.

Why

  • This extra and unnecessary field makes the operation more expensive.

Refs

ironFe93
ironFe93 reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I would ask @antomor to take a look as well

antomor
antomor requested changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to run the tests yet, but the changes look good to me!
The only thing that I noticed is the fact that the dist folder is missing in the updates.
Although we removed the dist folder, the types folder is still there.

@antomor
Copy link
Collaborator

antomor commented Jun 28, 2022

Closed in favour of #36

@antomor antomor closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 left review comments

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndresQuijano @antomor @ironFe93