Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

PP-137/Unnecessary domainSeparator field in Request #20

Closed
wants to merge 0 commits into from
Closed

PP-137/Unnecessary domainSeparator field in Request #20

wants to merge 0 commits into from

Conversation

AndresQuijano
Copy link
Contributor

@AndresQuijano AndresQuijano commented Jun 16, 2022 •
edited by antomor
Loading

What

  • Modify some types and functions in order to avoid passing the domain separator as part of the request and also as function parameters.

Why

  • This extra and unnecessary field makes the operation more expensive.

Refs

antomor
antomor approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dist folder is missing, but LGTM!
Just a doubt: is the function getDomainSeparatorHash used anywhere? If not, I'd remove it

@antomor antomor closed this Jun 28, 2022
@antomor
Copy link
Collaborator

antomor commented Jun 28, 2022

Closed in favor of #21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndresQuijano @antomor