Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimation-no-signature #96

Merged
merged 10 commits into from
Sep 2, 2024
Merged

estimation-no-signature #96

merged 10 commits into from
Sep 2, 2024

Conversation

franciscotobar
Copy link
Collaborator

@franciscotobar franciscotobar commented Sep 1, 2024

What

  • Estimation without signature

Why

  • UX improvement to not require additional signed tx

Refs

@franciscotobar franciscotobar changed the title Estimation no signature estimation-no-signature Sep 1, 2024
@franciscotobar franciscotobar marked this pull request as ready for review September 1, 2024 23:44
@franciscotobar franciscotobar force-pushed the estimation-no-signature branch from e79318a to 10aa040 Compare September 2, 2024 03:23
@franciscotobar
Copy link
Collaborator Author

We still need to decide the version.

package.json Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antomor

This comment was marked as duplicate.

@antomor
Copy link
Collaborator

antomor commented Sep 2, 2024

We decided to abandon the linear fit implementation and use a different approach, taking into account the costs involved into the different stages of the transaction and including some cushions to be sure the estimation is enough for executing the transaction.

@antomor antomor merged commit 63b84fe into main Sep 2, 2024
1 check passed
@antomor antomor deleted the estimation-no-signature branch September 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants