Initial setup of CI using GitHub Actions #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure `django-capture-on-commit-callbacks` is installed which is needed for testing - Fix typo in django32 config - Add tox-gh-actions - Remove unsupported python versions
- Remove usage of deprecated `assertEquals`. - Fix test `test_delete_should_return_default_django_value` which was failing under Django 3.0 and 3.1. These older versions of Django include a key with count of zero in the return value. In addition the test has been rewritten to reflect intent to reflect intent, i.e., test usage of `Model.delete()` instead of `QuerySet.delete()`. Introduced in: 2834786
|
Hi @rsinger86. I was away on holiday for a while. Was curious if you had a chance to look at this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective here is to get a working CI workflow setup using GitHub Actions as a replacement for Travis CI. This is prep work for additional changes in the pipeline, i.e. sun setting older Django versions and supporting newer ones and any other changes.
I wanted to have the tests passing (using tox) under the supported Python versions (3.7, 3.8, 3.9). An example of a successful run is here: https://github.com/emiel/django-lifecycle/actions/runs/2585559370.
The "Lint" job is an example of what could be done and we'd need to decide on what exactly we want to enforce. I tried to mimic what was already there for Travis. It is allowed to fail at the moment and we should come back to this.
See the individual commit messages for more details.
Addresses issue #100.
Let me know if you need more info.