Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up and enhance reading from (and writing to) a GRASS GIS database #93

Merged
merged 34 commits into from
Jun 18, 2024
Merged

Speed up and enhance reading from (and writing to) a GRASS GIS database #93

merged 34 commits into from
Jun 18, 2024

Commits on Jun 15, 2024

  1. readRAST.Rd: apply better fix than in 8df3a86

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    682c7fc View commit details
    Browse the repository at this point in the history

  2. read_RAST(): harden precondition for ignore.stderr

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    afa88cb View commit details
    Browse the repository at this point in the history

  3. Add internal helpers for the GDAL-GRASS drivers (raster & vector)

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    0f0525b View commit details
    Browse the repository at this point in the history

  4. read_RAST(): implement GDAL-GRASS driver by default (only with terra)

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    4389249 View commit details
    Browse the repository at this point in the history

  5. write_RAST(): error in case SpatRaster already linked to GRASS db

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    a06e782 View commit details
    Browse the repository at this point in the history

  6. read_VECT(): harden precondition for ignore.stderr

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    5162ec4 View commit details
    Browse the repository at this point in the history

  7. read_VECT(): drop superfluous coercion to character (done already)

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    cd9a0ea View commit details
    Browse the repository at this point in the history

  8. read_RAST(): isolate internal fns needed as well in read_VECT()

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    ff0831f View commit details
    Browse the repository at this point in the history

  9. read_VECT(), write_VECT(): set the ignore.stderr default in function()

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    7bc6744 View commit details
    Browse the repository at this point in the history

  10. read_VECT(): implement GDAL-GRASS driver by default

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    5806568 View commit details
    Browse the repository at this point in the history

  11. write_VECT(): harden precondition for ignore.stderr

    @florisvdh
    florisvdh committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    7991839 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. read_VECT(): add support for SpatVectorProxy

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    4aa9be3 View commit details
    Browse the repository at this point in the history

  2. write_VECT(): don't write temp GPKG when a source file exists

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    e93f7ca View commit details
    Browse the repository at this point in the history

  3. write_VECT(): error in case SpatVector already linked to GRASS db

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    31ccf56 View commit details
    Browse the repository at this point in the history

  4. read_VECT(): don't suppress driver messages

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0bc303c View commit details
    Browse the repository at this point in the history

  5. read_VECT(): allow missing layer arg with GDAL-GRASS driver * 

    vect() supports a missing layer argument, so supporting this too for GDAL-GRASS driver.

Also, for efficiency reasons, this commit only requests layer names in case
of polygons, to work around OSGeo/gdal-grass#46.
    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    bce663a View commit details
    Browse the repository at this point in the history

  6. read_VECT(): update debug message

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    de5da4d View commit details
    Browse the repository at this point in the history

  7. readRAST.Rd: add note on GDAL-GRASS driver missing CRS metadata

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    e1f026d View commit details
    Browse the repository at this point in the history

  8. readVECT.Rd: update documentation & add GDAL-GRASS note

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    f712436 View commit details
    Browse the repository at this point in the history

  9. DESCRIPTION: add codetools to Suggests

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    c32588d View commit details
    Browse the repository at this point in the history

  10. read_RAST(): move ignore.stderr backward in usage

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    f02dd46 View commit details
    Browse the repository at this point in the history

  11. read_RAST(): expose Sys_ignore.stdout argument

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    6a40b38 View commit details
    Browse the repository at this point in the history

  12. read_VECT(): expose Sys_ignore.stdout argument

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    a64ef0e View commit details
    Browse the repository at this point in the history

  13. execGRASS(): always respect ignore.stderr, Sys_ignore.stdout

    @florisvdh
    florisvdh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    87adff0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. readRAST.Rd examples: update code style

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3c749ce View commit details
    Browse the repository at this point in the history

  2. readRAST.Rd exmpl: take control of mapsets; only write to a custom one * 

    In the course of this fiddling with mapsets, it was seen (by accident) that the mapset
region settings are not respected by the GDAL driver.

This only affects raster.

This is a no-go for the GDAL-GRASS raster driver as long as it doesn't expose an option to
respect the mapset's current region, or at least to set a region.

A feature request will be made at the driver's repo, but as long as it's not implemented,
we cannot consider using the driver for rasters since results with and without using the
driver must of course have the same extent and resolution.

For sake of completeness, this commit takes control of the region too, in order to
guarantee that things always work. But this will be dropped from the examples in a next
commit, followed by dropping driver-related code from read_RAST() and write_RAST().
    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7eab282 View commit details
    Browse the repository at this point in the history

  3. readRAST.Rd exmpl: don't control region; should work with any region * 

    It was seen (by accident) that the mapset region settings are not respected by the GDAL
driver.

This only affects raster.

This is a no-go for the GDAL-GRASS raster driver as long as it doesn't expose an option to
respect the mapset's current region, or at least to set a region.

A feature request will be made at the driver's repo, but as long as it's not implemented,
we cannot consider using the driver for rasters since results with and without using the
driver must of course have the same extent and resolution.

So next is dropping driver-related code from read_RAST() and write_RAST().
    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0775029 View commit details
    Browse the repository at this point in the history

  4. read_RAST(), write_RAST(): drop GDAL-driver use (revert e1f026d, a06e782 

    , 4389249) *

In the course of this fiddling with mapsets, it was seen (by accident) that the mapset
region settings are not respected by the GDAL driver.

This only affects raster.

This is a no-go for the GDAL-GRASS raster driver as long as it doesn't expose an option to
respect the mapset's current region, or at least to set a region.

A feature request has been made at the driver's repo
(OSGeo/gdal-grass#49). As long as it's not implemented, we
cannot consider using the driver for rasters since results with and without using the
driver must of course have the same extent and resolution.
    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a828acf View commit details
    Browse the repository at this point in the history

  5. readVECT.Rd examples: update code style

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ed41230 View commit details
    Browse the repository at this point in the history

  6. readVECT.Rd exmpl: take control of mapsets; only write to a custom one

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    94c33cc View commit details
    Browse the repository at this point in the history

  7. readVECT.Rd exmpl: don't run vect2neigh(), it still writes in PERMANENT

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3738dd7 View commit details
    Browse the repository at this point in the history

  8. NEWS.md (0.4.3): use canonical name GRASS GIS

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b1e7251 View commit details
    Browse the repository at this point in the history

  9. NEWS.md: list new features for read_VECT(), write_VECT()

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b4c21f4 View commit details
    Browse the repository at this point in the history

  10. Update pkgdown site

    @florisvdh
    florisvdh committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    020fabc View commit details
    Browse the repository at this point in the history