Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if event exists when posting a message #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrekampert
Copy link
Contributor

When sending events, return 404 Not Found rather than 204 No Content in case the event does not exist. This prevents errors in event names or subscriber IDs from going unnoticed when using the pushd server.

  • broadcast: always succeeds
  • unicast:subscriber_id succeeds if subscriber exists
  • all other cases succeed only if the event is known

Fixes #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant