Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermetic: do not install buildroot via DNF #1524

Conversation

praiskup
Copy link
Member

Fixes: #1522

@Conan-Kudo
Copy link
Member

Why can't we have a fallback?

@praiskup
Copy link
Member Author

praiskup commented Dec 18, 2024

Why can't we have a fallback?

C&P from the towncrier snippet: it doesn't make sense because we don't have the bootstrap packages pre-downloaded in the local "offline" repository.

The repository only contains the packages that are needed to re-construct the buildroot repository (no DNF is there, typically).

@Conan-Kudo
Copy link
Member

So then... how does a build with dynamic buildrequires work? We need DNF there to be able to install more packages...

@praiskup
Copy link
Member Author

The hook that generates the lock file is "postdeps"; IOW we have all the dynamic build-deps covered in lockfile, and pre-downloaded in the offline repository (but not DNF, as that is typically not in BuildRequires).

@praiskup
Copy link
Member Author

We need DNF there to be able to install more packages...

Yeah and, ... DNF is provided by bootstrap_image_ready=True.

@praiskup
Copy link
Member Author

self-merging, so I can wrap the release, this seems rather trivial anyway

@praiskup praiskup merged commit a8a562e into rpm-software-management:main Dec 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hermetic: turn off the "normal bootstrap install"
2 participants