chroot_scan: create chroot_scan/ dir in buildroot.resultdir #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the real one now, also for the --chain method which is changing the
buildroot.resultdir for every single package. Previously, chroot_scan/
was (re)created for every --chain package in the basedir:
/var/lib/mock/fedora-41-x86_64/result/chroot_scan
Now, chroot_scan/ files are written into a package-specific resultdir,
for example:
/var/tmp/mock-chain-root-28259-ie_33sdi/results/default/copr-cli-2.0-1.git.15.526473b.fc41/chroot_scan
/var/tmp/mock-chain-root-28259-ie_33sdi/results/default/python-copr-2.0-1.git.20.526473b.fc41/chroot_scan
This in turn fixes a --chain build, because it - together with the
`chroo_scan` directory it created also `chroot_scan/..` directory,
mistakenly root-owned.
Fixes: rpm-software-management#1490
nikromen
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the real one now, also for the --chain method which is changing the buildroot.resultdir for every single package. Previously, chroot_scan/ was (re)created for every --chain package in the basedir:
Now, chroot_scan/ files are written into a package-specific resultdir, for example:
This in turn fixes a --chain build, because it - together with the
chroo_scandirectory it created alsochroot_scan/..directory, mistakenly root-owned.Fixes: #1490