Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the chroot_scan plugin #1472

Merged

Conversation

praiskup
Copy link
Member

No description provided.

This explains the permissions problems before aa9a5b0,
because while we created the plugin's result-directory (with root
permissions), the mock's (the main) resultdir was created as well as the
parent directory.  Both these directories were created with root:root
ownership, but only the sub-directory `chroot_scan` was later `chowned`
to the non-privileged user.

Complements: aa9a5b0
praiskup added a commit to praiskup/mock that referenced this pull request Sep 27, 2024
@pep8speaks
Copy link

pep8speaks commented Sep 27, 2024

Hello @praiskup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-27 14:47:11 UTC

praiskup added a commit to praiskup/mock that referenced this pull request Sep 27, 2024
@praiskup praiskup force-pushed the praiskup-chroot-scan-fix branch from 3c0983d to 95fa173 Compare September 27, 2024 13:33
praiskup added a commit to praiskup/mock that referenced this pull request Sep 27, 2024
praiskup added a commit to praiskup/mock that referenced this pull request Sep 27, 2024
@praiskup praiskup force-pushed the praiskup-chroot-scan-fix branch from 725c226 to db2e0a8 Compare September 27, 2024 14:42
praiskup added a commit to praiskup/mock that referenced this pull request Sep 27, 2024
@praiskup praiskup force-pushed the praiskup-chroot-scan-fix branch from db2e0a8 to 3ca4d24 Compare September 27, 2024 14:47
@praiskup praiskup added the release-blocker This needs to be shipped in the next release label Sep 27, 2024
@praiskup praiskup merged commit cc235e7 into rpm-software-management:main Sep 27, 2024
20 of 21 checks passed
praiskup added a commit that referenced this pull request Sep 27, 2024
praiskup added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This needs to be shipped in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants