Respect nspawn_args whenever doChroot is called #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
fix-chroot-bootstrap-nspawn-args
branch
from
6b0bf78 to
e3f6732
Compare
|
Please ignore the Pylint's similarity warning, it is an issue, but it is not a new thing (specific format that breaks csdiff comparison I believe). |
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 20, 2024
This also includes all `doOutChroot()` calls, as that method internally
calls `doChroot()`.
The issue was identified when trying to work around a problem [1] where
the SELinux policy prevented `systemd-machined` from creating a varlink
socket, causing it to fail to start. As a result, `systemd-nspawn`
could not register the machine. Tomáš tried the following
configuration:
config_opts['nspawn_args'] = ['--register=no']
This was intended to ensure that `systemd-nspawn` does not attempt to
register the machine with `systemd-machined`. However, the
configuration had no effect (the argument was not visible in the
`systemd-nspawn` command line, and the original issue persisted).
[1] https://issues.redhat.com/browse/RHEL-49567
Co-authored-by: Tomáš Hozza <[email protected]>
Closes: rpm-software-management#1410
Closes: rpm-software-management#1456
praiskup
force-pushed
the
fix-chroot-bootstrap-nspawn-args
branch
from
e3f6732 to
d223072
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 24, 2024
This also includes all `doOutChroot()` calls, as that method internally
calls `doChroot()`.
The issue was identified when trying to work around a problem [1] where
the SELinux policy prevented `systemd-machined` from creating a varlink
socket, causing it to fail to start. As a result, `systemd-nspawn`
could not register the machine. Tomáš tried the following
configuration:
config_opts['nspawn_args'] = ['--register=no']
This was intended to ensure that `systemd-nspawn` does not attempt to
register the machine with `systemd-machined`. However, the
configuration had no effect (the argument was not visible in the
`systemd-nspawn` command line, and the original issue persisted).
[1] https://issues.redhat.com/browse/RHEL-49567
Co-authored-by: Tomáš Hozza <[email protected]>
Closes: rpm-software-management#1410
Closes: rpm-software-management#1456
praiskup
force-pushed
the
fix-chroot-bootstrap-nspawn-args
branch
from
4ed9026 to
79cd1ad
Compare
xsuchy
pushed a commit
that referenced
this pull request
Sep 24, 2024
This also includes all `doOutChroot()` calls, as that method internally
calls `doChroot()`.
The issue was identified when trying to work around a problem [1] where
the SELinux policy prevented `systemd-machined` from creating a varlink
socket, causing it to fail to start. As a result, `systemd-nspawn`
could not register the machine. Tomáš tried the following
configuration:
config_opts['nspawn_args'] = ['--register=no']
This was intended to ensure that `systemd-nspawn` does not attempt to
register the machine with `systemd-machined`. However, the
configuration had no effect (the argument was not visible in the
`systemd-nspawn` command line, and the original issue persisted).
[1] https://issues.redhat.com/browse/RHEL-49567
Co-authored-by: Tomáš Hozza <[email protected]>
Closes: #1410
Closes: #1456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which also includes all doOutChroot(), because that method calls doChroot() internally.
This issue was found when trying to workaround an issue [1] when SELinux policy forbid systemd-machine to create a varlink socket and thus start. This resulted in systemd-nspawn not being able to register a machine. To workaround this, Tomáš added the following snippet to the configuration:
So that systemd-nspawn does not try to register the machine with systemd-machine. However, this had no effect (and the argument was not visible on command-line and still failed).
[1] https://issues.redhat.com/browse/RHEL-49567
Co-authored-with: Tomáš Hozza [email protected]