Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bootstrap container for CentOS Stream 10 #1451

Merged

Conversation

carlwgeorge
Copy link
Contributor

Since CentOS Stream 10 hasn't been released yet, the container image exists but is using the tag stream10-development instead of stream10. At some point (probably the release announcement) it will start using the stream10 tag. This image is "ready" (i.e. dnf builddep is pre-installed).

cc: @tdawson

Copy link

We were not able to find or create Copr project packit/rpm-software-management-mock-1451 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel: https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@praiskup
Copy link
Member

Nice! Thank you. Can you mark #1442 Fixed in the commit message?

@carlwgeorge carlwgeorge force-pushed the c10-bootstrap-container branch from c012c7d to a02b5fd Compare September 14, 2024 06:03
@carlwgeorge
Copy link
Contributor Author

Of course, amended the commit.

@praiskup
Copy link
Member

Two more things preferably in the same commit... would you please remove the temporary hack from behave config:

diff --git a/behave/features/isolated-build.feature b/behave/features/isolated-build.feature
index ffd623f5..ae22eb9a 100644
--- a/behave/features/isolated-build.feature
+++ b/behave/features/isolated-build.feature
@@ -12,9 +12,6 @@ Feature: Mock 5.7+ supports isolated builds
     @isolated_build
     Scenario: Isolated build against a DNF4 distribution
         Given an unique mock namespace
-        # Temporary image, until we resolve https://issues.redhat.com/browse/CS-2506
-        And next mock call uses --config-opts=bootstrap_image=quay.io/mock/behave-testing-c9s-bootstrap option
-        And next mock call uses --config-opts=bootstrap_image_ready=True option
         When deps for mock-test-bump-version-1-0.src.rpm are calculated against centos-stream+epel-9-x86_64
         And a local repository is created from lockfile
         And an isolated build is retriggered with the lockfile and repository

And provide a release note snippet? (towncrier create c10s-bootstrap-ready.config)

@praiskup
Copy link
Member

These are small things, let me know if you prefer me to do that in a separate commit...

@praiskup
Copy link
Member

Oh, taking back ... that is not a c10s test-case! And actually, the issue #1442 is related to CentOS Stream 8+, not just 10 - we we are not fixing the issue right now.

Can you please keep the issue open, i.e., s/Fixes/Relates/, keep the test-case as-is, but provide the release notes snippet?

Since CentOS Stream 10 hasn't been released yet, the container image
exists but is using the tag stream10-development instead of stream10.
At some point (probably the release announcement) it will start using
the stream10 tag.  This image is "ready" (i.e. python3-dnf-plugins-core
is pre-installed).

Relates: rpm-software-management#1442
@carlwgeorge carlwgeorge force-pushed the c10-bootstrap-container branch from a02b5fd to 225a633 Compare September 16, 2024 21:07
@carlwgeorge
Copy link
Contributor Author

No problem at all, if it makes sense in the same commit then that's how we should do it. I've amended again with those adjustments, let me know if there are any other tweaks needed.

@praiskup
Copy link
Member

PASSED: centos-stream+epel-10-x86_64.cfg (tmpfs)
PASSED: centos-stream+epel-10-x86_64.cfg

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praiskup praiskup merged commit 78f2fc5 into rpm-software-management:main Sep 17, 2024
20 checks passed
@carlwgeorge carlwgeorge deleted the c10-bootstrap-container branch September 17, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants