Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure --addrepo option also affects bootstrap #1415

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Ensure --addrepo option also affects bootstrap #1415

merged 1 commit into from
Sep 24, 2024

Conversation

praiskup
Copy link
Member

@praiskup praiskup commented Jul 24, 2024 •
edited
Loading

Fixes: #1414

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 24, 2024
View reviewed changes
mock/py/mockbuild/util.py Fixed Show fixed Hide fixed
@praiskup praiskup mentioned this pull request Jul 24, 2024
Closed
@xsuchy
Copy link
Member

xsuchy commented Aug 28, 2024

+1

@praiskup praiskup force-pushed the praiskup-issue-1414 branch 2 times, most recently from 4d897c1 to 40bc9e5 Compare September 19, 2024 13:00
@praiskup praiskup removed the blocked label Sep 19, 2024
@praiskup
Copy link
Member Author

I have changed my opinion on this, and I think it is worth merging. Let's help those users that really know what they are doing. Because, due to the fact how Mock caches bootstrap, the --addrepo will just "continue to have no effect" on most of the people out there.

@praiskup praiskup changed the title addrepo affects bootstrap Ensure --addrepo option also affects bootstrap Sep 19, 2024
@praiskup praiskup force-pushed the praiskup-issue-1414 branch 3 times, most recently from 8d77e1b to c4e9665 Compare September 24, 2024 06:55
@praiskup
Copy link
Member Author

I just rebased against main, to retrigger the Packit build.

@pep8speaks
Copy link

pep8speaks commented Sep 24, 2024 •
edited
Loading

Hello @praiskup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-24 12:42:40 UTC

xsuchy
xsuchy approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@xsuchy xsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xsuchy xsuchy merged commit d4c1269 into rpm-software-management:main Sep 24, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsuchy xsuchy xsuchy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--addrepo does not add repos to the boostrap chroot
3 participants
@praiskup @xsuchy @pep8speaks