Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Testing Farm testsuite #1405

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix the Testing Farm testsuite #1405

merged 2 commits into from
Jul 17, 2024

Conversation

praiskup
Copy link
Member

Mock has a build-in abstraction for in-bootstrap DNF version (or YUM), there's no need to check if DNF exists on host (this whole dropped test code comes from the pre-bootstrap era).

@praiskup
tests: don't enforce dnf4 installation into bootstrap
a8cf90f 
Mock has a build-in abstraction for in-bootstrap DNF version (or YUM),
there's no need to check if DNF exists on host (this whole dropped test
code comes from the pre-bootstrap era).
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/rpm-software-management-mock-1405 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=rpm-software-management-mock-1405 chroots=['fedora-40-x86_64', 'fedora-rawhide-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@praiskup
Copy link
Member Author

The one that needs a fix is:

* FAILED: /tmp/tmp.xIhyeOkcoZ-mock-old-tests/mock/integration-tests/22-rootdir.tst

@praiskup
tests: fix rootdir test for today's Fedora
a2728fe 
Something has changed in the Fedora's Kernel (in F39 or F40?) so that
special files do not work correctly below /tmp:

    $ sudo mknod -m 666 /tmp/null c 1 3
    $ cat /tmp/null
    cat: /tmp/null: Permission denied

This has broken our 22-rootdir.tst - the fix for this is to create the
rootdir below "$HOME" (one of the possibilities).

While touching this file, let's separate the --rootdir directories for
both isolation types.
@praiskup praiskup changed the title tests: don't enforce dnf4 installation into bootstrap Fix the Testing Farm testsuite Jul 16, 2024
@praiskup
Copy link
Member Author

Ready for merge:

*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/001-orphanskill-explicit.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/002-copyin.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/01-shell.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/02-argpassing.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/03-chroot-one-arg.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/04-offline-tmpfs.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/05-orphanskill-std.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/06-retcode.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/07-init-clean.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/08-oldstyle-cmd.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/09-mockchain-fail.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/10-mockchain-partial.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/11-mockchain-success.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/12-mockchain-recurse.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/13-mockchain-gen-br.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/14-mock-multiple.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/15-overlayfs-layers.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/16-spec-and-multiple-srpms-fail.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/17-spec-and-rebuild.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/18-spec-sources-and-rebuild.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/19-sign-plugin.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/20-lvm-plugin.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/21-mockchain-image.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/22-rootdir.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/23-local-mirrorlist.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/24-postinstall.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/25-postupdate-root-cache.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/26-external-deps.tst
*  PASSED: /tmp/tmp.w3I9VKoNCZ-mock-old-tests/mock/integration-tests/27-nspawn.tst

xsuchy
xsuchy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@xsuchy xsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xsuchy xsuchy merged commit 9666086 into rpm-software-management:main Jul 17, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsuchy xsuchy xsuchy approved these changes

Assignees
No one assigned
Labels
no-release-notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praiskup @xsuchy