-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configs: use DNF5-team-provided bootstrap images #1347
configs: use DNF5-team-provided bootstrap images #1347
Conversation
At least temporarily, till the default Fedora images do not contain dnf5 and dnf5-plugins by default. Fixes: rpm-software-management#1336
d2d4698
to
d21ad82
Compare
@inknos what do you think about this PR? As long as you/DNF5 team provide the support for those images, the PR would make the builds much faster. |
Blocked as the images do not provide all the needed architectures, yet. |
# once finished, we may use the default Fedora image. Now we are on nightlies | ||
# maintained by the RPM Software Management team. | ||
if int(config_opts['releasever']) >= 40: | ||
config_opts['package_manager'] = 'dnf5' | ||
config_opts['bootstrap_image'] = 'quay.io/rpmsoftwaremanagement/fedora-dnf5:{{ releasever }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fedora-dnf5:tag provides fedora with dnf5 installed from main repository. These images are rebuilt every day but they use the fedora:tag images and just istall dnf5 in it.
we actually have fedora-dnf5-nightly:tag which provides the nightly dnf5 builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an intentional choice, I don't think we want to use pre-release DNF5 images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah yeah I mean "Now we are on nightlies" is confusing. or at least confused me for a second :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, good point, I'm going to reword the docs :)
Closing because #1336 is closed as well. I hope we'll have DNF5-based default Fedora images soon. |
At least temporarily, till the default Fedora images do not contain dnf5 and dnf5-plugins by default.
Fixes: #1336