Group ownership and process ownership defaults to mock
#1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@praiskup can you rebase it, so it is easier to review - as this includes already merged CI commits. |
praiskup
force-pushed
the
praiskup-chown
branch
from
60628b2 to
3bf55e2
Compare
Hopefully, we do not open a can of worms.., but using GID=135 for non-privileged operations seems like the most expected Mock behavior. This way, we automatically maintain the ownership-bridge between the on-host user and the in-chroot user (both present in the 'mock' group). Mock started to map the unprivGid to the default GID of the on-host user in the commits 9c4e0f4 and 5cce73a, both are very old and it rather seems like a mistake than intention. Fixes: rpm-software-management#1257
Changing ownership of the entire $HOME directory tree is sometimes an expensive task and a no-op anyway because there's typically no reason for files with the wrong ownership to appear. Let's stop doing it to make the subsequent mock --chroot calls faster and more predictable. In other words, if users want to shoot themselves in the foot and give the files in '/builddir' away (e.g., using "privileged" --chroot calls), Mock will no longer fix the ownership problems. We only continue to fix the permissions for the --rebuild mode, which shouldn't be expensive (because there are pre-build cleanups) and seems important enough to risk changing. Suggested by @kdudka in rpm-software-management#1257.
praiskup
force-pushed
the
praiskup-chown
branch
from
3bf55e2 to
e726010
Compare
xsuchy
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address #1257