configs: BuildWithDNF5 for ELN #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2024
|
Let's hold off on this for a few more days; I've got two related MRs out that we should land first:
Then we can avoid needing to turn off the |
|
Can this proceed now? |
|
Yeah, we have to... this is breaking Copr builds. |
praiskup
commented
May 14, 2024
| # Used to be True per https://github.com/fedora-eln/eln/issues/166 but with | ||
| # the 'dnf5' we are switching to False, reobserve after | ||
| # https://fedoraproject.org/wiki/Changes/ReplaceDnfWithDnf5 applied to ELN! | ||
| config_opts['bootstrap_image_ready'] = False |
There was a problem hiding this comment.
Unfortunately, we made this change in ELN stack in the wrong order -> the ELN image now contains dnf5 and not dnf4, so it stays "ready". Going to update..
praiskup
force-pushed
the
praiskup-eln-dnf5
branch
from
725827a to
b771d95
Compare
praiskup
force-pushed
the
praiskup-eln-dnf5
branch
from
b771d95 to
a4471a1
Compare
praiskup
force-pushed
the
praiskup-eln-dnf5
branch
from
a4471a1 to
f1c5a46
Compare
|
I just tested the proposed config and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: https://pagure.io/releng/issue/11895