Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report file system type #1276

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Dec 14, 2023

Previously, only the file sizes were reported:

Filesystem                                             Size  Used Avail Use% Mounted on
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  399G  9.1G  373G   3% /
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  399G  9.1G  373G   3% /

Newly, also file system type will be reported:

Filesystem                                             Type   Size  Used Avail Use% Mounted on
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  btrfs  399G  9.1G  373G   3% /
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  btrfs  399G  9.1G  373G   3% /

This is useful in case file system influeces the build result.

Fixes #1263

@voxik
Copy link
Contributor Author

voxik commented Dec 14, 2023

I have not really tested the change, though 😇

@praiskup
Copy link
Member

LGTM, would you mind adding a new release note entry? https://rpm-software-management.github.io/mock/Release-Notes-New-Entry

Previously, only the file sizes were reported:

~~~
Filesystem                                             Size  Used Avail Use% Mounted on
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  399G  9.1G  373G   3% /
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  399G  9.1G  373G   3% /
~~~

Newly, also file system type will be reported:

~~~
Filesystem                                             Type   Size  Used Avail Use% Mounted on
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  btrfs  399G  9.1G  373G   3% /
/dev/mapper/luks-3aa4fbe3-5a19-4025-b70c-1d3038b76bd4  btrfs  399G  9.1G  373G   3% /
~~~

This is useful in case file system influeces the build result.

Fixes rpm-software-management#1263
@voxik
Copy link
Contributor Author

voxik commented Dec 18, 2023

LGTM, would you mind adding a new release note entry?

Ufff, this is complicated for random contributor 🥵

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@praiskup praiskup merged commit 1c857d7 into rpm-software-management:main Jan 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include FS type in hw_info.log
2 participants