Also log command line for still running process #1255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
praiskup
reviewed
Nov 14, 2023
| @@ -177,6 +177,8 @@ def orphansKill(rootToKill, manual_forced=False): | |||
| root = os.readlink("/proc/%s/root" % fn) | |||
| if compare_two_paths_cached(root, rootToKill, path_cache): | |||
| getLog().warning("Process ID %s still running in chroot. Killing with %s...", fn, killsig) | |||
| with open("/proc/%s/cmdline" % fn) as f: | |||
| getLog().warning("Process is %s", f.readline()) | |||
There was a problem hiding this comment.
Thank you. Can this end up with any exception that would potentially skip the os.kill() call?
remicollet
force-pushed
the
issue-procstillrunning
branch
from
7242087 to
1d6502b
Compare
|
Looking deeper, "cmdline" is a list of strings, with NUL as separator... Should be |
|
Could this work? |
|
Ok, thank you for your idea here! I'm trying to finalize this in #1268, feedback is welcome. |
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Dec 12, 2023
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Dec 12, 2023
praiskup
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we have in log
This is not easy to debug, especially as the process is killed, so doesn't exist anymore
With this PR we have
Which may be more useful
NOTICE: my python skill are close to 0, so this is mostly a RFE ;)
Perhaps a single line will be preferred (with cmdline instead of pid) ?