Add rpmautospec plugin

[nphilipp]

This plugin preprocesses spec files using %autorelease and/or %autochangelog in the mock chroot prior to building SRPMs. The rpmautospec package will be installed into the chroot if necessary.

/cc @sgallagher

[nphilipp]

The rpm-build:fedora-rawhide-x86_64:mock check failed because the unit tests depend on the rpmautospec-core Python package which needs to be available as an RPM package in Fedora, see fedora-infra/rpmautospec-core#10, and mock.spec needs to be adapted, too.

[github-advanced-security]

vcs-diff-lint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[praiskup]

Thank you for your contribution! Nice.

Can you please document the plugin https://rpm-software-management.github.io/mock/#plugins ?

Some of the new PyLint warnings are too pedantic (I'm going to tweak the
rules), though some are worth fixing (plus I'd vote for having at least
some of those non-test doc strings written, not a hard requirement).

The rpmautospec package will be installed into the chroot if necessary.

But we also require it also host because of
from rpmautospec_core import specfile_uses_rpmautospec.

Have you considered calling the host tooling (on the sources stored in-chroot)?

[praiskup]

Also, can you please write a release notes entry, template:

$ cat releng/release-notes-next/autospec.feature 
New plugin ... [has been implemented][PR#1254] ...
...

[praiskup]

Can you please also add a "commented out" plugin-config into the docs file ./mock/docs/site-defaults.cfg? We document all the available options there.

[pep8speaks]

Hello @nphilipp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file mock/py/mockbuild/plugins/rpmautospec.py:

Line 98:21: W503 line break before binary operator

• In the file mock/tests/plugins/test_rpmautospec.py:

Line 199:21: W503 line break before binary operator

Comment last updated at 2023-12-07 13:16:31 UTC

[nphilipp]

Hello @nphilipp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

* In the file [`mock/py/mockbuild/plugins/rpmautospec.py`](https://github.com/rpm-software-management/mock/blob/0fd14985906a58701acc8f6697735195364b1a60/mock/py/mockbuild/plugins/rpmautospec.py):

Line 98:21: W503 line break before binary operator

* In the file [`mock/tests/plugins/test_rpmautospec.py`](https://github.com/rpm-software-management/mock/blob/0fd14985906a58701acc8f6697735195364b1a60/mock/tests/plugins/test_rpmautospec.py):

Line 199:21: W503 line break before binary operator

This actually conforms to what PEP8 says about breaking lines around binary operators: https://peps.python.org/pep-0008/#should-a-line-break-before-or-after-a-binary-operator

[praiskup]

Two missing things:

• No matching package to install: 'python3-rpmautospec-core' in EPEL 8.
• documenting why we need to run the in-chroot autospec tooling

[nphilipp]

I’ve set the PR to be ready for review (which I should have done a while ago already).

Two missing things:

* `No matching package to install: 'python3-rpmautospec-core'` in EPEL 8.

The new package update has been in testing for a couple of days: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9e47a8b73c

I’m trying to get karma for it 😉.

* documenting why we need to run the in-chroot autospec tooling

I'll do this (and squash the commits into one).

[nphilipp]

@praiskup the update should be available with the next EPEL8 compose and I’ve added the reasons for doing this in the chroot as a comment.

[praiskup]

LGTM, thank you.

[praiskup]

Have you considered calling the host tooling (on the sources stored in-chroot)?

Just getting back to this; I still think this is a bad idea.

The Mock's mission should be to abstract from the in-chroot nuances, and rely on "easily fixable" on-host tooling (by example, that way you can bootstrap a new distribution without having the autospec tooling built yet, or build fedora packages with autospec against distributions that do not support it).