Fix '~' user source expansion for --copyout #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
praiskup-copyout-homedir
branch
from
fda9d0c to
b29539e
Compare
tuliom
reviewed
Sep 18, 2023
| Previous versions of Mock mistakenly expanded every `~` occurrence | ||
| (tilde character) in the specified source path with `--copyout`. So | ||
| files `~/foo~bar.txt` were searched on path `/builddir/foo/builddirbar.txt` | ||
| instead of just `/biulddir/foo~bar.txt`. Fixes [rhbz#2239035][]. |
There was a problem hiding this comment.
There is a minor typo in the path in this line:
/biulddir/foo~bar.txt instead of /builddir/foo~bar.txt
There was a problem hiding this comment.
Heh, do you mean the additional just word? Sorry my eyes are tired today :D
There was a problem hiding this comment.
@praiskup No. builddir is spelled wrong with i coming before u: biuld
There was a problem hiding this comment.
Indeed, good catch. Thanks!
praiskup
force-pushed
the
praiskup-copyout-homedir
branch
from
b29539e to
aa9a1c3
Compare
xsuchy
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.