Keep re-creating the root directory #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 18, 2023
praiskup
force-pushed
the
praiskup-rootdir-creation-in-5.1
branch
from
0f5f308 to
68c35fd
Compare
praiskup
force-pushed
the
praiskup-rootdir-creation-in-5.1
branch
from
68c35fd to
4055c98
Compare
praiskup
merged commit c068147
into
rpm-software-management:main
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 1e13b56 causes that basedir is only created once, but at appropriate time.
The bug caused by that commit was that also
$basedir/rootmkdir(rootdir) action was mistakenly moved into the _setup_basedir(). Because rootdir is always removed after a build (if --resultdir is specified), we have to re-create it before trying to re-mount the rootdir.This has caused problems in Fedora Copr which switched to 'mock --spec foo.spec --sources
pwd'. This action actually does two builds, SRPM and later RPMs. The second build was unable to re-mount the rootdir with:ERROR: Command failed:
$ mount -n -t tmpfs -o mode=0755 -o nr_inodes=0 -o size=140g mock_chroot_tmpfs /var/lib/mock/fedora-37-x86_64-1694797505.326095/root